Skip to content

[develop] Fix a bug that was causing compute node self‑termination to hang on Ubuntu 24.04 nodes #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented May 13, 2025

Description of changes

  • Detect OS before run the self-termination command
  • If the OS is ubuntu2404, run systemctl poweroff --force instead of shutdown -h now
  • Added test cases to cover the changes

Tests

  • I created a AL2 and Ubuntu2404 cluster to manually test. Test done. Works as expected.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 requested review from a team as code owners May 13, 2025 05:28
@hehe7318 hehe7318 added the 3.x label May 13, 2025
@hehe7318 hehe7318 merged commit 1039234 into aws:develop May 15, 2025
9 checks passed
hehe7318 added a commit to hehe7318/aws-parallelcluster-node that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants